Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parser for official case counts in Ontario, Canada #705

Merged
merged 1 commit into from
May 26, 2020

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented May 25, 2020

Related issues and PRs

Description

This adds a dedicated case counts parser for Ontario province of Canada.
The data is taken from the website of the government of Ontario.

Impacted Areas in the application

data, case counts

Testing

@ivan-aksamentov ivan-aksamentov added t:feat Type: request of a new feature, functionality, enchancement s:data Scope: related to data retrieval, parsing, transformation, storage, update labels May 25, 2020
@vercel
Copy link

vercel bot commented May 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covid19-scenarios/covid19-scenarios/6dot4davt
✅ Preview: https://covid19-scenarios-git-feat-data-canada-ontario.covid19-scenarios.now.sh

Comment on lines +16 to +21
'Reported Date': 'time',
'Total Cases': 'cases',
'Deaths': 'deaths',
'Number of patients hospitalized with COVID-19': 'hospitalized',
'Number of patients in ICU with COVID-19': 'icu',
'Resolved': 'recovered',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the mapping of columns

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   24.58%   24.58%           
=======================================
  Files         134      134           
  Lines        2896     2896           
  Branches      386      386           
=======================================
  Hits          712      712           
  Misses       2184     2184           

@codeclimate
Copy link

codeclimate bot commented May 25, 2020

Code Climate has analyzed commit 40c3b72 and detected 0 issues on this pull request.

View more on Code Climate.

@rneher
Copy link
Member

rneher commented May 25, 2020

this looks great. thanks. your solution with pandas is nice and leaner than what most other parsers do.

@rneher rneher merged commit 2ef378b into master May 26, 2020
@rneher rneher deleted the feat/data-canada-ontario branch May 26, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:data Scope: related to data retrieval, parsing, transformation, storage, update t:feat Type: request of a new feature, functionality, enchancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants